Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dtype_backend=pyarrow in documentation #54733

Closed
wants to merge 2 commits into from
Closed

adding dtype_backend=pyarrow in documentation #54733

wants to merge 2 commits into from

Conversation

JumpingDino
Copy link

  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Issue took from here

@JumpingDino
Copy link
Author

@phofl @noatamir this PR was done in the berlin meetup.
Tagging you as requested :)

@mroeschke mroeschke added the Sprints Sprint Pull Requests label Aug 24, 2023
@mroeschke mroeschke requested review from noatamir and phofl August 25, 2023 18:00
@@ -492,6 +492,21 @@ Setting ``dtype_backend="numpy_nullable"`` will result in nullable dtypes for ev

.. _io.categorical:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to remove that one, it's duplicated now in line 508 as well

@JumpingDino
Copy link
Author

just removed the line, is this okay?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 3, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprints Sprint Pull Requests Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants