Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: fillna 'method' #53394

Closed
jbrockmendel opened this issue May 25, 2023 · 2 comments · Fixed by #53496
Closed

DEPR: fillna 'method' #53394

jbrockmendel opened this issue May 25, 2023 · 2 comments · Fixed by #53496
Labels
Deprecate Functionality to remove in pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Milestone
2.1

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented May 25, 2023 •
edited
Loading

Seems like obj.fillna(method="ffill") is redundant with obj.ffill(). If that is accurate, we should deprecate the method keyword in fillna.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels May 25, 2023
@topper-123 topper-123 added Deprecate Functionality to remove in pandas and removed Bug labels May 26, 2023
@lithomas1 lithomas1 added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Needs Discussion Requires discussion from core team before further action and removed Needs Triage Issue that has not been reviewed by a pandas team member labels May 27, 2023
@jreback
Copy link
Contributor

jreback commented May 31, 2023

+1 this is duplicative

@jbrockmendel jbrockmendel mentioned this issue Jun 1, 2023
Merged
5 tasks
@rhshadrach rhshadrach added this to the 2.1 milestone Jun 7, 2023
@rhshadrach rhshadrach removed the Needs Discussion Requires discussion from core team before further action label Jun 7, 2023
@nathanramoscfa nathanramoscfa mentioned this issue Sep 13, 2023
Merged
@winedarksea
Copy link

-1 this required lots of code changes for no clear benefit to pandas
don't break stuff without clear benefit is my vote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

DEPR: fillna method kwd jbrockmendel/pandas
6 participants
@jreback @jbrockmendel @topper-123 @winedarksea @rhshadrach @lithomas1