Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Different result with ẞ in Series.str.upper when using Arrow string dtype vs pd.StringDtype() #52037

Closed
2 of 3 tasks
rohanjain101 opened this issue Mar 16, 2023 · 8 comments
Labels
Arrow pyarrow functionality Docs Strings String extension data type and string data Upstream issue Issue related to pandas dependency

Comments

@rohanjain101
Copy link
Contributor

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

>>> a = pd.Series(["ß"], dtype="string[pyarrow]")
>>> a.str.upper()
0    

Issue Description

The result does not match the result produced match the result of pd.StringDtype(), which would produce:

a_str = pd.Series(["ß"], dtype=pd.StringDtype())
a_str.str.upper()
0 SS

Is this difference in Series.str.upper between the arrow type and pandas extension type intentional?

Expected Behavior

a_str = pd.Series(["ß"], dtype=pd.StringDtype())

a_str.str.upper()
0 SS
dtype: string

Installed Versions

pd.show_versions()

INSTALLED VERSIONS

commit : 1a2e300
python : 3.8.10.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.22621
machine : AMD64
processor : Intel64 Family 6 Model 85 Stepping 7, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : English_United States.1252

pandas : 2.0.0rc0
numpy : 1.24.2
pytz : 2022.7.1
dateutil : 2.8.2
setuptools : 67.2.0
pip : 22.3.1
Cython : None
pytest : None
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader: None
bs4 : None
bottleneck : None
brotli : None
fastparquet : 2023.2.0
fsspec : 2023.3.0
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 11.0.0
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
snappy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
zstandard : None
tzdata : None
qtpy : None
pyqt5 : None

@rohanjain101 rohanjain101 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 16, 2023
@rohanjain101
Copy link
Contributor Author

rohanjain101 commented Mar 16, 2023

FWIW, the python upper method (which Series.str.upper is documented to be equivalent to), would produce "SS" which matches the pandas extension type:

char = "ß"
char.upper()
'SS'

@mroeschke
Copy link
Member

Could you report this to the pyarrow tracker?

In [1]: import pyarrow as pa

In [2]: pa.compute.utf8_upper("ß")
Out[2]: <pyarrow.StringScalar: 'ẞ'>

In [3]: pa.__version__
Out[3]: '11.0.0'

@mroeschke mroeschke changed the title BUG: Different result in Series.str.upper when using Arrow string dtype vs pd.StringDtype() BUG: Different result with ẞ in Series.str.upper when using Arrow string dtype vs pd.StringDtype() Mar 17, 2023
@mroeschke mroeschke added Strings String extension data type and string data Upstream issue Issue related to pandas dependency Arrow pyarrow functionality and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 17, 2023
@rohanjain101
Copy link
Contributor Author

@mroeschke do you mean creating an issue on the arrow github under the python category? Or is there a different (dedicated for pyarrow) place I should report this?

@mroeschke
Copy link
Member

do you mean creating an issue on the arrow github under the python category?

Correct, there is one tracker for all language implementations: https://github.com/apache/arrow/issues/new/choose

BTW thanks for all the pyarrow testing. We're really eager to see the use cases and also improve pyarrow so pandas gets the improvements as well.

@rohanjain101
Copy link
Contributor Author

Created the issue: apache/arrow#34599. And no problem, happy to help and really excited to see pandas supporting arrow as a backend.

@rohanjain101
Copy link
Contributor Author

Based on the issue, looks like the difference is intentional in the library arrow relies on, so not sure if maybe the docs should be updated that it might not necessarily match str.upper with the arrow type.

@mroeschke mroeschke added Docs and removed Bug labels Mar 17, 2023
@randolf-scholz
Copy link
Contributor

randolf-scholz commented Jul 19, 2023

Python's upper is outdated here. SS is the old way of capitalizing ß in German. However, in 2008 the new unicode symbol was introduces and became a part of the ISO/IEC 10646 standard. Since 2017, is the official capitalized version of ß according to official German Orthography. wikipedia: Großes ß

Issue in cpython was closed: python/cpython#81294

@mroeschke
Copy link
Member

Seems like this is an upstream issue, going to close as special casing in pandas isn't appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Docs Strings String extension data type and string data Upstream issue Issue related to pandas dependency
Projects
None yet
Development

No branches or pull requests

3 participants