From 7ae1a5edd274e4ea488cb1a0f1baa67785b415bf Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 19 Dec 2024 10:02:09 +0100 Subject: [PATCH] fix tests for default mode --- pandas/tests/frame/methods/test_replace.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/pandas/tests/frame/methods/test_replace.py b/pandas/tests/frame/methods/test_replace.py index a62d51987f454..ef1f13c8df928 100644 --- a/pandas/tests/frame/methods/test_replace.py +++ b/pandas/tests/frame/methods/test_replace.py @@ -292,7 +292,7 @@ def test_regex_replace_dict_nested_gh4115(self): df = DataFrame( {"Type": Series(["Q", "T", "Q", "Q", "T"], dtype=object), "tmp": 2} ) - expected = DataFrame({"Type": Series([0, 1, 0, 0, 1], dtype=object), "tmp": 2}) + expected = DataFrame({"Type": [0, 1, 0, 0, 1], "tmp": 2}) msg = "Downcasting behavior in `replace`" with tm.assert_produces_warning(FutureWarning, match=msg): result = df.replace({"Type": {"Q": 0, "T": 1}}) @@ -304,7 +304,7 @@ def test_regex_replace_list_to_scalar(self, mix_abc): expec = DataFrame( { "a": mix_abc["a"], - "b": Series([np.nan] * 4, dtype="str"), + "b": [np.nan] * 4, "c": [np.nan, np.nan, np.nan, "d"], } ) @@ -1633,14 +1633,6 @@ def test_replace_regex_dtype_frame(self, regex): expected_df2 = DataFrame({"A": [1], "B": ["1"]}) with tm.assert_produces_warning(FutureWarning, match=msg): result_df2 = df2.replace(to_replace="0", value=1, regex=regex) - - if regex: - # TODO(infer_string): both string columns get cast to object, - # while only needed for column A - expected_df2 = DataFrame({"A": [1], "B": ["1"]}, dtype=object) - else: - expected_df2 = DataFrame({"A": Series([1], dtype=object), "B": ["1"]}) - result_df2 = df2.replace(to_replace="0", value=1, regex=regex) tm.assert_frame_equal(result_df2, expected_df2) def test_replace_with_value_also_being_replaced(self):