Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning if timber plugin or class deosn't exist #7

Open
palmiak opened this issue Oct 14, 2019 · 2 comments
Open

Add a warning if timber plugin or class deosn't exist #7

palmiak opened this issue Oct 14, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@palmiak
Copy link
Owner

palmiak commented Oct 14, 2019

Now if user will install Timber ACF WP Blocks he'll get a fatal error if Timber is not installed. It should be fixed.

@palmiak palmiak added the good first issue Good for newcomers label Oct 14, 2019
@landwire
Copy link

Could that not be solved by adding "timber" as a required package in the composer.json?

"require": {
    "php": ">=5.6",
    "timber/timber": "1.*"
}

In the end you need timber for this to work, right?

@jdamner
Copy link
Contributor

jdamner commented Jan 7, 2021

Timber can be installed in other methods/contexts, so would be better to check if (class_exists(“Timber”))

palmiak added a commit that referenced this issue Aug 27, 2021
#7 - Add validation Timber exists before instatiation of class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants