Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Deprecate dbt versions < 1.0.1 #85

Open
1 task done
mariahjrogers opened this issue Jul 26, 2023 · 3 comments
Open
1 task done

✨ Deprecate dbt versions < 1.0.1 #85

mariahjrogers opened this issue Jul 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@mariahjrogers
Copy link
Collaborator

Context
dbt now has 5 minor versions in V1 so palm should support all five and deprecate support below V1.

Is your feature request related to a problem? Please describe.
Palm rejects the two newest dbt minor versions, which it should support. Also, <= V0.19 is not supported by dbt any longer, so it doesn't need to be supported by palm either.

Describe the solution you'd like
Deprecate v0.19 and add support for dbt v1.4 and v1.5

Describe alternatives you've considered
N/A

Additional context

Is there an existing feature request for this?

  • I have searched the existing issues
@mariahjrogers mariahjrogers added the enhancement New feature or request label Jul 26, 2023
@jakeberesford-palmetto
Copy link
Collaborator

Thanks for creating this issue. We will need to keep supporting dbt v0.19 for now since we have a legacy project running on that version. As soon as we are able to drop support internally, we will!

We are also using palm-dbt with dbt v1.4 and haven't run into any issues. Can you provide reproduction instructions for "Palm rejects the two newest dbt minor versions"

@mariahjrogers
Copy link
Collaborator Author

Specifically, palm containerize doesn't allow you to generate new boilerplate if you specify a version greater than 1.3. I am sure a manually created image would work just fine but the maximum_version property specifies 1.3 as the max supported version.

@jakeberesford-palmetto
Copy link
Collaborator

Would you mind creating a new issue to increase the maximum supported version for containerization? That can (and should) be done separately from deprecating support for <v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants