Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #46

Open
1 task done
jakeberesford-palmetto opened this issue Dec 9, 2021 · 0 comments
Open
1 task done

Improve test coverage #46

jakeberesford-palmetto opened this issue Dec 9, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jakeberesford-palmetto
Copy link
Collaborator

Context
Our test coverage on this plugin is not great. It would be great to take the time to test as much of the code as we can.

Is your feature request related to a problem? Please describe.
No, this is an improvement that will help keep the codebase healthy in the long-run.

Describe the solution you'd like
Implement tests for the following (in loose priority order):

  • dbt_plugin.py + plugins/dbt/init.py
  • dbt_palm_utils.py
  • sql_to_dbt_.py
  • local_user_lookup.py
  • Commands (this may be very tricky, take a shot but consider breaking this out to a separate issue if there are significant troubles writing meaningful tests around these)

Describe alternatives you've considered
Don't test the code, watch the project crumble over time.

Additional context
We are using pytest, there are already some tests around dbt_containerizer, look at palm-cli test_cli.py for reference in re. testing commands.

Is there an existing feature request for this?

  • I have searched the existing issues
@jakeberesford-palmetto jakeberesford-palmetto added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant