Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting autoFocus={false} causes unexpected broken functionality #17

Open
tonypee opened this issue Oct 20, 2020 · 1 comment
Open

Setting autoFocus={false} causes unexpected broken functionality #17

tonypee opened this issue Oct 20, 2020 · 1 comment

Comments

@tonypee
Copy link
Contributor

tonypee commented Oct 20, 2020

The demo has autoFocus={true}, but if you change it to 'false' everything breaks. This is fairly unintuitive, and costly if you dont realize that that was the cause (my case)

https://codesandbox.io/s/radio-group-demo-forked-s8c6s?file=/src/index.js

@tonypee
Copy link
Contributor Author

tonypee commented Oct 25, 2020

It seems that the Radio elements dont focus themselves when they become selected by keyboard, as that incorrectly relies on the autoFocus flag - here's a PR:
#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant