Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling assets raises an error #35

Closed
stiig opened this issue Jun 16, 2023 · 3 comments · May be fixed by #37
Closed

Compiling assets raises an error #35

stiig opened this issue Jun 16, 2023 · 3 comments · May be fixed by #37
Assignees
@palkan

Comments

@stiig
Copy link

stiig commented Jun 16, 2023 •
edited
Loading

What did you do?

#20 [stage-1 11/11] RUN RAILS_ENV=staging bundle exec rake assets:precompile

What did you expect to happen?

Generated assets

What actually happened?

#20 6.164 NoMethodError: undefined method `autoloaders' for Rails:Module
#20 6.164 Did you mean?  autoloads
#20 6.164                autoload
#20 6.164                autoload?
#20 6.164                autoload_at
#20 6.165 /usr/local/bundle/gems/view_component-contrib-0.1.4/lib/view_component_contrib/railtie.rb:12:in `block in <class:Railtie>'

Additional context

Environment

Ruby Version:
ruby 2.7.5p203 (2021-11-24 revision f69aeb8314) [x86_64-darwin21]

Framework Version (Rails, whatever):
Rails 5.2.8.1

View Component Contrib Version:
view_component (3.2.0)
view_component-contrib (0.1.4)
@palkan
Copy link
Owner

palkan commented Aug 17, 2023

Hey!

Sorry for late response.

We never tested against Rails 5. Though, I see that ViewComponent still supports 5.2. Let me check if there is a quick fix (in the worst case we can disable some features for now).

@palkan palkan mentioned this issue Aug 17, 2023
Draft
3 tasks
@palkan
Copy link
Owner

palkan commented Aug 17, 2023

I opened a PR here to check if we can add Rails 5 support: #37

The above issue is fixed but some tests still fail. I'm not going to dig into it anytime soon but if you give this branch a try and provide your feedback—I would appreciate it.

@palkan palkan added the question Further information is requested label Aug 17, 2023
@stiig
Copy link
Author

stiig commented Oct 1, 2024

I think we can close this issue and related PR, ViewComponent has started supporting rails 6.1+
https://viewcomponent.org/compatibility.html

@stiig stiig closed this as completed Oct 1, 2024
@palkan palkan removed the question Further information is requested label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palkan palkan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rails 5 support palkan/view_component-contrib
2 participants
@palkan @stiig