Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecation): use async_update_entry when handling config entries #157

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Mar 7, 2024

Related Issues

Proposed Changes:

Config entries are updated using async_update_entry instead of using config attributes directly. In particular:

  • Migrations don't use config.version = 2 anymore
  • Tests don't use a custom MockConfigEntry mock, in favor of the one provided by hass.fixtures (original HA fixtures)
  • All tests are updated to use both the MockConfigEntry and async_update_entry

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8189921946

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.979%

Totals Coverage Status
Change from base Build 8160514738: -0.01%
Covered Lines: 674
Relevant Lines: 721

💛 - Coveralls

@palazzem palazzem merged commit c8a2221 into main Mar 7, 2024
4 of 5 checks passed
@palazzem palazzem deleted the palazzem/issue-156 branch March 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Address deprecation warnings for Home Assistant 2024.3.0
2 participants