Fix missing jars in classpath of generared in jar MANIFEST #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to resolve palantir#476
Test for resolution of palantir#476
|
Thanks for your interest in palantir/sls-packaging, @joncelay! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| FileCollection runtimeClasspath = project.getConfigurations().getByName("runtimeClasspath"); | ||
|
|
||
| TaskProvider<Jar> jarTask = project.getTasks().withType(Jar.class) | ||
| .named(JavaPlugin.JAR_TASK_NAME); |
There was a problem hiding this comment.
could we inline this into the below? also can do getByName rather than named if you're just gonna .get() it right afterwards
dansanduleac
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #476
Classpath in jar MANIFEST now contains the project jars and is consistent with the classpath generated in launcher script.