You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See internal atlasdb proxy client, issue 1333: builds there are failing on being unable to read the manifest.
The integration spec also looks like it produces an invalid manifest: if I add these lines to the bottom of the test
// What is of interest here is that this does not throw an exception
shadowJarFile().getManifest().getAttributes("Multi-Release")
an exception on reading the manifest is thrown.
I believe the problem here is that ManifestResourceAppender simply adds key-value pairs to the end of a file. So you end up with a problem where if a manifest already ends with an empty line (which looks like something internal to the shadow plugin), then appending ends up getting
Manifest-Version: 1.0
Multi-Release: true
which is not a valid format; it should really be
Manifest-Version: 1.0
Multi-Release: true
I'd write a PR, but have struggled with dependencies/possible classpath issues for >2 hours...
Turns out 2.5 hours was the magic mark!
The text was updated successfully, but these errors were encountered:
jeremyk-91
changed the title
Handling of multi-release jars produces an invalid manifest
Shading of multi-release jars produces an invalid manifest
Dec 7, 2020
See internal atlasdb proxy client, issue 1333: builds there are failing on being unable to read the manifest.
The integration spec also looks like it produces an invalid manifest: if I add these lines to the bottom of the test
an exception on reading the manifest is thrown.
I believe the problem here is that
ManifestResourceAppender
simply adds key-value pairs to the end of a file. So you end up with a problem where if a manifest already ends with an empty line (which looks like something internal to the shadow plugin), then appending ends up gettingwhich is not a valid format; it should really be
I'd write a PR, but have struggled with dependencies/possible classpath issues for >2 hours...Turns out 2.5 hours was the magic mark!
The text was updated successfully, but these errors were encountered: