Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shading slf4j causes logs to not appear #125

Open
Jolyon-S opened this issue Apr 8, 2021 · 2 comments
Open

Shading slf4j causes logs to not appear #125

Jolyon-S opened this issue Apr 8, 2021 · 2 comments

Comments

@Jolyon-S
Copy link

Jolyon-S commented Apr 8, 2021

Using an slf4j logger inside of a shaded project causes the logs to never actually get logged in the right way as slf4j also gets shaded inside that project, and it won't discover any of the actual logger impls.

@j-baker
Copy link
Contributor

j-baker commented Apr 8, 2021

The implication - should we ban shading slf4j?

@carterkozak
Copy link
Contributor

Same problem applies to metric registries which rely on SharedMetricRegistries/SharedTaggedMetricRegistry.
The default configuration could be more helpful to avoid specitic foot-guns, but I don't think we can realistically solve this class of problems as long as we're shading classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants