Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tagging if an endpoint is read or write #364

Open
sixinli opened this issue Aug 14, 2019 · 2 comments
Open

add support for tagging if an endpoint is read or write #364

sixinli opened this issue Aug 14, 2019 · 2 comments

Comments

@sixinli
Copy link

sixinli commented Aug 14, 2019

it would be useful for consumer to know the potential side effects of the endpoints

@iamdanfox
Copy link
Contributor

@sixinli I think my concern with adding this extra metadata is I don't know how we could make sure it was correct. I.e. what if an endpoint was annotated as READ_ONLY but then someone actually made the endpoint do a migration-on-read that involved copying some data to a new store. The annotation of 'read/write' becomes a bit fuzzy at this point, and I'm not sure what value can be derived from metadata that is not always accurate.

@sixinli
Copy link
Author

sixinli commented Jan 23, 2020

thats a valid concern... its hard to enforce because people can technically do anything they want even with a GET endpoint... this is more just for good practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants