Routing for ambiguous service endpoints is not specified

[sfackler]

Consider the following (legal) Conjure definition:

services:
  FooService:
    name: FooService
    package: com.palantir.conjure
    base-path: /foo
    endpoints:
      first:
        http: GET /foo/{param}
        args:
          param: string
      second:
        http: GET /{param}/foo
        args:
          param: string

What is the expected behavior if I make an HTTP request to /foo/foo/foo? That matches both endpoint definitions.

[ferozco]

We specify this (with an example) in the docs. In your case, /foo/foo/foo would match with /foo/{param}

[sfackler]

Ideally we'd have a rule and not one example.

[ferozco]

agreed. I'll flesh out the rule

[sfackler]

While you're in there, it'd be great to handle #297 as well :)

[ferozco]

Actually, it seems like I can't read the docs. We already specify: When comparing multiple paths, the path with the longest concrete path should be matched first.

[sfackler]

That still sounds ambiguous to me I think. Imagine GET /foo/{param1}/bar/{param2} and GET /foo/{param1}/{param2}/bar. They both have a 1-element concrete path, right?

Assuming I understand what's intended, a more robust specification could be something like:

Convert the candidate paths into sequences of literal/parameter values, and take the lexicographic maximum with literal being greater than parameter.

In the example above, that'd look like comparing [concrete, param, concrete, param] and [concrete, param, param, concrete], and the first path would be matched.