Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remoting3's UserAgent here #59

Open
ash211 opened this issue Nov 16, 2017 · 3 comments
Open

Move remoting3's UserAgent here #59

ash211 opened this issue Nov 16, 2017 · 3 comments

Comments

@ash211
Copy link
Contributor

ash211 commented Nov 16, 2017

https://github.com/palantir/http-remoting/blob/develop/http-clients/src/main/java/com/palantir/remoting3/clients/UserAgent.java

@ash211
Copy link
Contributor Author

ash211 commented Jan 22, 2018

@uschi2000 @j-baker this is important for an internal library that needs to accept UserAgents as part of its API. I'd prefer for that to be an object in http-remoting-api than in remoting3.

Are we able to move remoting3's UserAgent into remoting-api without requiring a bump to remoting4?

@uschi2000
Copy link
Contributor

Don't think we can move it without going to remoting4.

@ash211
Copy link
Contributor Author

ash211 commented Jan 23, 2018

Ok I'll use name/version for now, and just do another API major version break in foundry-spark when we go to remoting-api.UserAgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants