Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set cert_allowed_uses as variable when create jwt cert #108

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andrea-putzu
Copy link

List of changes

Set cert_allowed_uses as variable with default value: ["digital_signature"].
This field is currently mandatory in selfcare but not needed in pnpg.selfcare.

Motivation and context

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

@andrea-putzu andrea-putzu requested review from a team and diegolagospagopa May 4, 2023 14:53
// "key_encipherment"
]
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can you add a description?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description added as comment

@diegolagospagopa diegolagospagopa dismissed their stale review May 5, 2023 11:13

miss changes

@andrea-putzu andrea-putzu requested a review from a team as a code owner February 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants