Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] github_actions_identity module #103

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Apr 18, 2023

List of changes

  • Added new module

Motivation and context

I don't know how to contribute proficiently to this repo, but still I spotted the opportunity to propose this module, as we are currently repeating the same configuration across several repository.

The intended usage should be

module my_gh_actions {
  source = "git::https://github.com/pagopa/terraform-azurerm-v3.git//github_actions_identity?ref=v6.3.0"
  
  project = "my-app"
  env = "prod"

  environment_cd_roles = {
    subscription = [
      "Reader",
    ]
    resource_groups = {
      my-app-rg = [
        "Website Contributor",
      ]
    }
  }

  github_repository_environment_cd = {
    protected_branches     = true
    custom_branch_policies = false
    reviewers_teams        = ["my-team"]
  }

}

Type of changes

  • [*] Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

@balanza balanza requested review from a team and diegolagospagopa April 18, 2023 12:01
@balanza balanza requested review from pasqualedevita and removed request for diegolagospagopa April 18, 2023 12:18
@balanza balanza marked this pull request as draft April 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant