Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set domain variable as optional on cosmosdb_account module #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Apr 17, 2023

List of changes

  • set domain variable optional on cosmosdb_account module

Motivation and context

The value is documented as optional, but it's actually required.

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

@balanza balanza requested review from a team and diegolagospagopa April 17, 2023 17:01
@balanza balanza changed the title Fix-optional-arg (fix) Set domain variable optional on cosmosdb_account module Apr 17, 2023
@balanza
Copy link
Contributor Author

balanza commented Apr 17, 2023

Besides the fix, I wonder what the domain variable actually means. The name sounds to me like a kind of namespacing or partitioning word, but it's just used to name the cosmos_db_provisioned_throughput_exceeded metric.

Should we remove/rename it?

@balanza balanza changed the title (fix) Set domain variable optional on cosmosdb_account module fix: Set domain variable optional on cosmosdb_account module Apr 17, 2023
@balanza balanza changed the title fix: Set domain variable optional on cosmosdb_account module fix: Set domain variable as optional on cosmosdb_account module Apr 17, 2023
@balanza balanza requested review from fmlisco and removed request for diegolagospagopa April 17, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant