From 0d1a8a71488892e1f89a7af6112368ef594137c5 Mon Sep 17 00:00:00 2001
From: Diego Lagos <92735530+diegolagospagopa@users.noreply.github.com>
Date: Wed, 18 Jan 2023 17:06:13 +0100
Subject: [PATCH] feat: Kubernetes pod identity migrated from v2 (#36)

updated migration guide
---
 docs/MIGRATION_FROM_V2.md         | 27 ++++++++++++++-------------
 kubernetes_pod_identity/README.md | 13 ++++++++++---
 kubernetes_pod_identity/main.tf   |  1 -
 3 files changed, 24 insertions(+), 17 deletions(-)

diff --git a/docs/MIGRATION_FROM_V2.md b/docs/MIGRATION_FROM_V2.md
index 559e64e6..78d77eec 100644
--- a/docs/MIGRATION_FROM_V2.md
+++ b/docs/MIGRATION_FROM_V2.md
@@ -2,16 +2,17 @@
 
 <https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/3.0-upgrade-guide>
 
-| module                | status | note  |
-|--------               |--------|-------|
-| storage-account       | ok     | read migration guide |
-| cosmosdb              | ok     | read migration guide |
-| subnet                | ok     | read migration guide |
-| vnet                  | ok     | read migration guide |
-| vpn                   | ok     | read migration guide |
-| postgresql-flexible   | ok     | read migration guide |
-| postgresql-server     | ok     | read migration guide |
-| app-gateway           | ok     | read migration guide |
-| cdn                   | ok     | read migration guide |
-| jwt-keys              | ok     | read migration guide |
-| kubernetes_cluster    | ok     | state import mandatory + read migration guide |
+| module                  | status | note  |
+|--------                 |--------|-------|
+| storage-account         | ok     | read migration guide |
+| cosmosdb                | ok     | read migration guide |
+| subnet                  | ok     | read migration guide |
+| vnet                    | ok     | read migration guide |
+| vpn                     | ok     | read migration guide |
+| postgresql-flexible     | ok     | read migration guide |
+| postgresql-server       | ok     | read migration guide |
+| app-gateway             | ok     | read migration guide |
+| cdn                     | ok     | read migration guide |
+| jwt-keys                | ok     | read migration guide |
+| kubernetes_pod_identity | ok     | read migration guide |
+| kubernetes_cluster      | ok     | state import mandatory + read migration guide |
diff --git a/kubernetes_pod_identity/README.md b/kubernetes_pod_identity/README.md
index 657e137f..2cb78967 100644
--- a/kubernetes_pod_identity/README.md
+++ b/kubernetes_pod_identity/README.md
@@ -20,12 +20,19 @@ module "ingress_pod_identity" {
   cluster_name        = "dvopla-d-aks"
   namespace           = "helm-template"
 
-  certificate_permissions = ["get"]
-  key_permissions         = ["get"]
-  secret_permissions      = ["get"]
+  certificate_permissions = ["Get"]
+  key_permissions         = ["Get"]
+  secret_permissions      = ["Get"]
 }
 ```
 
+## Migration from v2
+
+1️⃣ Arguments changed:
+
+* `certificate_permissions`, `key_permissions` and `secret_permissions` related to keyvault access policy, must start with a capitol letter. E.g [Backup Delete Get List Purge Recover Restore Set]
+
+
 <!-- markdownlint-disable -->
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
diff --git a/kubernetes_pod_identity/main.tf b/kubernetes_pod_identity/main.tf
index 8cfbdfff..68af3960 100644
--- a/kubernetes_pod_identity/main.tf
+++ b/kubernetes_pod_identity/main.tf
@@ -50,4 +50,3 @@ resource "null_resource" "create_pod_identity" {
     EOT
   }
 }
-