Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-6094] feat: set mobile phone field in sc-users queue message #236

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Nov 29, 2024

List of Changes

  • add mobilePhone field in sc-users queue message (in UserToNotify object in user-sdk)
  • align NotificationMapper in ms-user
  • align NotificationMapper in user-cdc
  • update user-registry openapi
  • add unit tests

Motivation and Context

This change enables the inclusion of the 'mobilePhone' field in the messages sent to the sc-users queue.

How Has This Been Tested?

It was tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarcloud bot commented Nov 29, 2024

@giulia-tremolada giulia-tremolada marked this pull request as ready for review November 29, 2024 17:42
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner November 29, 2024 17:42
@giulia-tremolada giulia-tremolada marked this pull request as draft December 2, 2024 09:02
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant