Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-6085] feat: add mobilePhone field in retrieveUsers API response #234

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[SELC-6085] feat: add mobilePhone field in retrieveUsers API response #234

merged 2 commits into from
Nov 28, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Nov 28, 2024 •
edited
Loading

List of Changes

  • add mobilePhone field in retrieveUsers API response
  • align mappers
  • align unit tests
  • align openapi

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review November 28, 2024 15:29
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner November 28, 2024 15:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AleDore
AleDore approved these changes Nov 28, 2024
View reviewed changes
Copy link

@AleDore AleDore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giulia-tremolada giulia-tremolada merged commit a59271a into main Nov 28, 2024
9 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-6085 branch November 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleDore AleDore AleDore approved these changes

Assignees
No one assigned
Labels
user-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @AleDore