Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-324] feat: origin check when setting payer fiscal code on receipt #54

Merged

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Jan 11, 2024

List of Changes

  • Introduced env variable to define authenticated origin list
  • Updated RecoverFailed API with checks to avoid setting payerfFiscalCode whenever the origin does not come from an authenticated origin
  • Updated RegenerateReceiptPdf API with checks to avoid setting payerfFiscalCode whenever the origin does not come from an authenticated origin
  • Updated unit tests

Motivation and Context

https://pagopa.atlassian.net/browse/PRDP-324

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…eceiptUtils to manage authenticated origin filter when setting payer fiscal code on receipt creation/recover
…zed payer fiscal code if not fromn an unauthenticated origin
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@pasqualespica pasqualespica merged commit 19ca374 into main Jan 22, 2024
5 of 8 checks passed
Copy link

sonarcloud bot commented Jan 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants