Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-289] feat: add failed cart recovery #49

Merged
merged 33 commits into from
Jan 8, 2024

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Jan 4, 2024

List of Changes

  • Introducing RecoverFailedCart http function
  • Introducing RecoverFailedCartMassive http function
  • Introducing RecoverFailedCartScheduled cron triggered function
  • Updated unit tests

Motivation and Context

https://pagopa.atlassian.net/browse/PRDP-289

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

alexyey and others added 25 commits December 15, 2023 15:00
…covery' into PRDP-289-feat-add-failed-cart-recovery
…covery' into PRDP-289-feat-add-failed-cart-recovery

# Conflicts:
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverFailedCart.java
#	src/test/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverFailedReceiptTest.java
#	src/test/java/it/gov/pagopa/receipt/pdf/helpdesk/utils/BizEventToReceiptUtilsTest.java
…e and scheduled. Updated RecoverFailedCartTest
…e and scheduled. Updated RecoverFailedCartTest
…covery' into PRDP-289-feat-add-failed-cart-recovery

# Conflicts:
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverFailedCartMassive.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverFailedCartScheduled.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/client/BizEventCosmosClient.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/client/impl/BizEventCosmosClientImpl.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/entity/cart/CartForReceipt.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/entity/receipt/Receipt.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/exception/CartNotFoundException.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/service/BizEventToReceiptService.java
#	src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/service/impl/BizEventToReceiptServiceImpl.java
#	src/test/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverFailedCartTest.java
#	src/test/java/it/gov/pagopa/receipt/pdf/helpdesk/service/impl/BizEventToReceiptServiceImplTest.java
@alessio-cialini alessio-cialini changed the title Prdp 289 feat add failed cart recovery [PRDP-289] feat: add failed cart recovery Jan 4, 2024
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

23 New issues
0 Security Hotspots
83.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -886,6 +895,241 @@
}
]
},
"/cart/{cart-id}/recover-failed": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo carts

Copy link

github-actions bot commented Jan 8, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

github-actions bot commented Jan 8, 2024

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@pasqualespica
Copy link
Contributor

🔝

@pasqualespica pasqualespica merged commit 670e019 into main Jan 8, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants