Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRDP-237 Add recover api IO_ERROR_TO_NOTIFY and GENERATED status #4

Merged

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Nov 28, 2023

List of Changes

  • added new RecoverNotNotifiedReceipt function
  • updated unit test
  • updated openapi.json
  • updated README

Motivation and Context

Add recover API for receipts in IO_ERROR_TO_NOTIFY and GENERATED status

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella force-pushed the PRDP-237-recover-api-for-io-error-to-notify-status branch from 6d119e8 to 332514f Compare November 28, 2023 15:58
@gioelemella gioelemella force-pushed the PRDP-237-recover-api-for-io-error-to-notify-status branch from 332514f to a71d9cf Compare November 28, 2023 16:02
@gioelemella gioelemella marked this pull request as ready for review November 28, 2023 16:05
@pasqualespica pasqualespica changed the title [PRDP-237] feat: Add recover api IO_ERROR_TO_NOTIFY and GENERATED status feat: PRDP-237 Add recover api IO_ERROR_TO_NOTIFY and GENERATED status Nov 28, 2023
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

69.7% 69.7% Coverage
0.4% 0.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 0b6dec5 into main Nov 28, 2023
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants