Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [PagoPA-1181]: BIN by range #107

Merged
merged 7 commits into from
Sep 12, 2023
Merged

feat: [PagoPA-1181]: BIN by range #107

merged 7 commits into from
Sep 12, 2023

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • modified search in the issuer table using the LOW and HIGH range columns instead of the BIN column

Motivation and Context

  • standardize the search behavior in the table with what NEXI does

How Has This Been Tested?

Manual, Junit and Integration test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli added enhancement New feature or request minor labels Sep 12, 2023
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@alessio-acitelli
Copy link
Collaborator Author

update_code

@alessio-acitelli alessio-acitelli marked this pull request as ready for review September 12, 2023 08:35
FedericoRuzzier
FedericoRuzzier approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@alessio-acitelli alessio-acitelli merged commit 5761833 into main Sep 12, 2023
11 checks passed
@alessio-acitelli alessio-acitelli deleted the PAGOPA-1181-bin-by-range branch September 12, 2023 13:40
@alessio-acitelli alessio-acitelli temporarily deployed to dev September 12, 2023 13:42 — with GitHub Actions Inactive
@alessio-acitelli alessio-acitelli temporarily deployed to dev September 12, 2023 13:43 — with GitHub Actions Inactive
@alessio-acitelli alessio-acitelli temporarily deployed to dev September 12, 2023 13:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
enhancement New feature or request minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @FedericoRuzzier @pasqualespica