Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input lag when pressing buttons on Android #1814

Open
bfabio opened this issue May 15, 2020 · 8 comments
Open

Input lag when pressing buttons on Android #1814

bfabio opened this issue May 15, 2020 · 8 comments

Comments

@bfabio
Copy link
Contributor

bfabio commented May 15, 2020

There's a noticeable input lag when pressing buttons on Android with every device I have. Granted they're not the fastest out there, but neither will be the average device where IO will be installed, besides, it happens on the emulator as well.

If I had to eyeball it, I wanna say there's about a 100ms delay between the touch and the ripple animation which makes the app look sluggish and not reactive. I think this is due to crossing the React Native bridge.

This is eb86a36 running on the emulator: https://imgur.com/a/8K2gZzk

and this is a patch using BaseButton from react-native-gesture-handler, which doesn't cross the bridge. Please ignore the lack of styling for now: https://imgur.com/a/ZBvwLdG

It makes a world of difference in how the app's performance is perceived.

Smartphone

  • Device: One Plus One, Xiaomi Mi A1, Emulator
  • OS: Android 9, Android 10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Sep 8, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

@bfabio
Copy link
Contributor Author

bfabio commented Sep 26, 2021

@pietro909 @fabriziofff I'm not sure autoclosing stale issues after a while is a good idea. This one is still valid.

@fabriziofff fabriziofff removed the stale label Sep 29, 2021
@fabriziofff
Copy link
Contributor

The autoclosure occurs only if there are no further comments from the reporter or anyone else within the next 14 days, after being marked as a stale. In case the issue is still valid we can reopen it without problem!

@fabriziofff fabriziofff reopened this Sep 29, 2021
@bfabio
Copy link
Contributor Author

bfabio commented Sep 29, 2021

@fabriziofff thanks! :)

@pietro909
Copy link
Contributor

@bfabio first off, thank you for your valuable report and effort. I understand that keeping this issue in line for some ~18 months must feel frustrating.

With that being said, I kindly ask you please to confirm whether the issue is still valid with the last configuration you reported and the latest production tag 1.36.0-rc.2:

Device: One Plus One, Xiaomi Mi A1, Emulator
OS: Android 9, Android 10

We'll then use this newer information to triage the issue internally.
Thanks!

@bfabio
Copy link
Contributor Author

bfabio commented Nov 30, 2021

@pietro909 don't worry, I know the changes required can touch a lot of code and most likely need to be postponed to a quieter time :)

I'm perfectly fine with just having the issue tracked and acknowledge IO strives for great UX experience - which it already does (who knows, someone might even pick up the work)

I can confirm the issue is still valid for the Emulator and my One Plus One. I can't confirm with my Mi A1 because I dropped it down a flight of stairs a few months ago :(

@pietro909
Copy link
Contributor

Tracked via https://pagopa.atlassian.net/browse/IA-632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants