Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pending pacts in Bidirectional contract tests #104

Open
roshanmathewjohn opened this issue Aug 9, 2023 · 1 comment
Open
Labels
feature request New feature or request

Comments

@roshanmathewjohn
Copy link

roshanmathewjohn commented Aug 9, 2023

Reference: https://docs.pact.io/pact_broker/advanced_topics/pending_pacts

"Pending pacts" is a feature for providers, to avoid new consumer expectations breaking the tests and blocking their pipeline.

In Bidirectional contract testing world, how do we set a newly published OAS as pending to prevent consumer tests from failing?

@mefellows
Copy link
Contributor

Thanks for raising @roshanmathewjohn!

Pending Pacts is not something currently supported for our BDCT flow. Pending Pacts works on the provider verification step in Pact - something that is not analogous in BDCT. It is expected that teams use the can-i-deploy feature alongside environments and branches to determine if a change is safe. In this case, a consumer would not be able to add a feature (expectation) the provider doesn’t provide and then also deploy it to an environment that would cause a breaking change for the provider.

It may make sense to support this in a can-i-merge scenario, so will leave this open for further discussion.

@mefellows mefellows added the feature request New feature or request label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants