fix: return a 400 when invalid JSON is used to create a version

lib/pact_broker/api/resources/base_resource.rb

@@ -152,6 +152,10 @@ def request_body
           @request_body ||= request.body.to_s
         end
 
+        def any_request_body?
+          request_body && request_body.size > 0
+        end
+
         def consumer_name
           identifier_from_path[:consumer_name]
         end

lib/pact_broker/api/resources/version.rb

@@ -25,6 +25,14 @@ def resource_exists?
           !!version
         end
 
+        def malformed_request?
+          if request.put? && any_request_body?
+            invalid_json?
+          else
+            false
+          end
+        end
+
         def from_json
           if request.really_put?
             handle_request do

spec/lib/pact_broker/api/resources/version_spec.rb

@@ -0,0 +1,23 @@
+require "pact_broker/api/resources/version"
+
+module PactBroker
+  module Api
+    module Resources
+      describe Version do
+        let(:path) { "/pacticipants/Foo/versions/1" }
+
+        context "with an empty body" do
+          subject { put(path, nil, "CONTENT_TYPE" => "application/json") }
+
+          its(:status) { is_expected.to eq 201 }
+        end
+
+        context "with invalid JSON" do
+          subject { put(path, { some: "yaml" }.to_yaml, "CONTENT_TYPE" => "application/json") }
+
+          its(:status) { is_expected.to eq 400 }
+        end
+      end
+    end
+  end
+end