Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI: Headers configured with provider state generator have invalid paths in Pact file #355

Closed
rholshausen opened this issue Jan 15, 2024 · 1 comment
Closed

FFI: Headers configured with provider state generator have invalid paths in Pact file #355

rholshausen opened this issue Jan 15, 2024 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@rholshausen
Copy link
Contributor

Headers configure with JSON like

{"expression":"${seToken}","pact:generator:type":"ProviderState","pact:matcher:type":"type","value":"ABC123"}

end up with incorrect generators and matchers in the generated Pact file

"$['se-token'][0]": {
    "expression": "${seToken}",
    "type": "ProviderState"
}

Downstream issue pact-foundation/pact-js#1144
@rholshausen rholshausen added the bug Indicates an unexpected problem or unintended behavior label Jan 15, 2024
rholshausen added a commit that referenced this issue Jan 15, 2024
@rholshausen
fix: matching rules and generators for headers could be written to JS…
6e5504c 
…ON form incorrectly #355
rholshausen added a commit that referenced this issue Jan 16, 2024
@rholshausen
chore: Upgrade pact_models to 1.1.13 #355
dfd1376
rholshausen added a commit that referenced this issue Jan 16, 2024
@rholshausen
fix(FFI): Headers configured with provider state generator have inval…
9d121e5 
…id paths in Pact file #355
rholshausen added a commit that referenced this issue Jan 16, 2024
@rholshausen
fix: Support V2 matching rule header/query paths in encoded format #355
d94c782
rholshausen added a commit that referenced this issue Jan 16, 2024
@rholshausen
chore: Upgrade pact_models to 1.1.14 #355
403c0af
rholshausen added a commit that referenced this issue Jan 16, 2024
@rholshausen
fix(compatibility-suite): fix compatibility suite after change to Pac…
1f7a565 
…t models crate #355
@rholshausen
Copy link
Contributor Author

Pact FFI Library 0.4.12 released

@rholshausen rholshausen mentioned this issue Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rholshausen