Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to provide more info when a pact merge conflict occurrs #2

Closed
uglyog opened this issue Sep 18, 2016 · 1 comment
Closed

Need to provide more info when a pact merge conflict occurrs #2

uglyog opened this issue Sep 18, 2016 · 1 comment

Comments

@uglyog
Copy link
Member

uglyog commented Sep 18, 2016

When there is a merge conflict, the consumer test fails with something like

expected to be equal to <PactVerified>, got <PactError("Unable to merge pacts, as there were 1 conflict(s) between the interactions")>
@emk emk mentioned this issue Oct 7, 2017
30 tasks
rholshausen added a commit that referenced this issue Feb 20, 2024
… d22d4667..416f3a64

416f3a64 Fix grammar in README.md
bb740850 feat: Add interaction description to the published verification results
ec373503 Merge pull request #6 from tienvx/disable-kafka
c693b549 chore: Add @wip tag to Kafka scenario
db548451 Merge pull request #2 from tienvx/remove-duplicated-scenarios
96c35a0c chore: Remove duplicated scenarios

git-subtree-dir: compatibility-suite/pact-compatibility-suite
git-subtree-split: 416f3a64d49bee977b0f404a5ba3002eae570eb3
@YOU54F
Copy link
Member

YOU54F commented Jun 9, 2024

Is this still required or can it be considered complete?

118daa1

There were some improvements in the above commit to provide more granular information on mismatches.

It looks like we collect errors and report back

message pact errors -

Err(anyhow!("Unable to merge pacts: {}", errors.join(", ")))

sync pact errors -

if errors.is_empty() {

do we need to do the same in the v4 merge func

.map(|either| match either {
Left(i) => i.clone(),
Right(i) => i,
Both(_, i) => i.clone()
})
.collect(),
metadata: self.metadata.clone()
})
} else {
Err(s!("Unable to merge pacts, as they have different consumers or providers"))
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants