Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generators): Pass back result from provider state setup URL #53

Closed
wants to merge 1 commit into from

Conversation

hhhonzik
Copy link
Contributor

@hhhonzik hhhonzik commented Feb 23, 2020

Addressing issue I've previously mentioned here #49

Best is to see what's inside a new test contract - we provide a generators object which can override the tested request. I've implemented generator ProviderState, which although is not part of the spec, is implemented in pact-jvm described here

I just want to raise a conversation early, if the approach is approvable in a future or I should change the implementation.

      ....
      "request": {
        "method": "GET",
        "path": "/book/1",
        "generators": {
          "path": {
            "type": "ProviderState",
            "expression": "/book/${id}"
          }
        }
      },
      ....

TODO:

@bethesque
Copy link
Member

@uglyog what's with the generator not being part of the spec?

@uglyog
Copy link
Member

uglyog commented Feb 27, 2020

Because you never wrote the spec for it ;-)

@bethesque
Copy link
Member

I was busy :P

Looks good though @hhhonzik, keep going!

@bethesque
Copy link
Member

Where is this at @hhhonzik?

@YOU54F
Copy link
Member

YOU54F commented Apr 25, 2022

Hey @hhhonzik thanks for your efforts on this pull request and others,

Are you still looking to work on them, or would you require feedback or anything to help. If not thank you and we will look to see how we can incorporate these ideas in the future

#49
pact-foundation/pact-ruby#209
pact-foundation/pact-support#79

@YOU54F
Copy link
Member

YOU54F commented Aug 6, 2024

closed in favour of #85 and pact-foundation/pact-ruby#273

@YOU54F YOU54F closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants