Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PACT CRASHED #524

Closed
uttam-gelot opened this issue Sep 5, 2024 · 13 comments
Closed

PACT CRASHED #524

uttam-gelot opened this issue Sep 5, 2024 · 13 comments
Labels
awaiting feedback Awaiting Feedback from OP

Comments

@uttam-gelot
Copy link

Software versions

  • OS: Ubuntu
  • @pact-foundation/pact: 10.4.0
  • Node Version: 20.14.0
  • nestjs-pact: 2.3.1

Some more information

  • I'm using NestJS version: 10.4.1
  • I'm using nestjs-pact library with version: 2.3.1
  • all the test cases are failing due to failed verification.
  • I'm facing issue when I upgraded versions of nestjs-pact from v2.2.1 to v.2.3.1 and @pact-foundation/pact from v.9.18.1 to v.10.4.0

I'm getting below errors:
image
image
image

@uttam-gelot uttam-gelot added the bug Indicates an unexpected problem or unintended behavior label Sep 5, 2024
@uttam-gelot
Copy link
Author

@mefellows @YOU54F could you please look into it?

@mefellows
Copy link
Member

Please provide a repro

@mefellows mefellows added awaiting feedback Awaiting Feedback from OP and removed bug Indicates an unexpected problem or unintended behavior labels Sep 5, 2024
@uttam-gelot
Copy link
Author

Please provide a repro

@mefellows I've large codebase in which this issue is occurring. creating repository will take time. in the message it mentioned to report so I reported it.

@mefellows
Copy link
Member

Thanks, we don't need your actual code just some code that reproduces the error. The migration from 9-10 was a significant change.

P.a. you need not tag maintainers, we already subscribe to all issues.

@uttam-gelot
Copy link
Author

Got it. I'm trying to create repo. I'll share here once ready.

P.a. you need not tag maintainers, we already subscribe to all issues.

Okay. thank you.

@YOU54F
Copy link
Member

YOU54F commented Sep 5, 2024

For extra bonus points and internet karma, provide a repository, gist or reproducible code snippet so that we can test the problem.

☝🏾 in the new issue template

I'll be honest and say nestjs-pact has stalled in terms of development, and I'm personally spread over too many things to be massively driven to do anything about it, so we would either ask for contributions to fix it, or suggest migrating to using pact-js directly.

@uttam-gelot
Copy link
Author

creating repo will take time for me maybe I can do it over weekend but for now I've created Gist. Let me know if you need anything else.

@YOU54F
Copy link
Member

YOU54F commented Sep 6, 2024

@uttam-gelot
Copy link
Author

this one was helpful. thank you @YOU54F

@mefellows
Copy link
Member

Thanks Yousaf!

@uttam-gelot
Copy link
Author

I removed nestjs-pact and using jest-pact.

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Oct 28, 2024

I removed nestjs-pact and using jest-pact.

Does this mean your issue is fixed? If so, this ticket can be closed.

@uttam-gelot
Copy link
Author

Yes, it's working. I'm closing it thank you everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Awaiting Feedback from OP
Projects
None yet
Development

No branches or pull requests

4 participants