fix(tenacity-git): upd pacscript to new version #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR OK for me, Testing fail but it's fine like this. |
Elsie19
requested changes
Dec 8, 2024
I don't understand. The script was broken. I have fixed it. I also incremented the version to fit the new revision. Maybe need a better title ? Sorry, really I don't understand what you want :) |
|
Any package update can include fixes and don't have to be labeled as a fix. So you should change the title to an |
Elsie19
requested changes
Dec 11, 2024
| incompatible=("ubuntu:bionic" "ubuntu:focal" "ubuntu:jammy" "debian:stretch" "debian:buster" "debian:bullseye") | ||
| replaces=("audacity") | ||
| maintainer=("echometerain <[email protected]>" "xdavius <[email protected]>") | ||
|
|
| for i in *; do # fix for png icons not following hicolor category folders | ||
| cd "${i}" | ||
| mkdir -p apps | ||
| test -f tenacity.png && mv tenacity.png apps |
There was a problem hiding this comment.
Suggested change
| test -f tenacity.png && mv tenacity.png apps | |
| [[ -f tenacity.png ]] && mv tenacity.png apps |
| -Wno-dev \ | ||
| .. | ||
| cmake --build . | ||
| make -j"$(NCPU)" . |
There was a problem hiding this comment.
Suggested change
| make -j"$(NCPU)" . | |
| make -j"${NCPU}" . |
| cmake --install build | ||
| cd tenacity/build | ||
| make DESTDIR="${pkgdir}" install | ||
| test -f "${pkgdir}/usr/tenacity" && rm "${pkgdir}/usr/tenacity" # remove unused launch script |
There was a problem hiding this comment.
Suggested change
| test -f "${pkgdir}/usr/tenacity" && rm "${pkgdir}/usr/tenacity" # remove unused launch script | |
| [[ -f "${pkgdir}/usr/tenacity" ]] && rm "${pkgdir}/usr/tenacity" # remove unused launch script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.