Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023 python packaging #798

Closed
11 tasks done
TomasTomecek opened this issue Feb 9, 2023 · 2 comments · Fixed by #808
Closed
11 tasks done

2023 python packaging #798

TomasTomecek opened this issue Feb 9, 2023 · 2 comments · Fixed by #808
Labels
area/other Related to some other area/category than the specified ones. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. good-first-issue Good for newcomers. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 9, 2023 •
edited by nforro
Loading

  • all our projects DO NOT use setup.py and have pyproject.toml instead
  • all our specfiles use the new pyproject-rpm-macros (%pyproject_{wheel,install,save_*})
    • packit
    • ogr
    • specfile
  • all builds in packit are passing
  • testing farm tests are green
  • specfiles are up to date in src.fp.o
@TomasTomecek TomasTomecek added the area/fedora Related to Fedora ecosystem label Feb 9, 2023
majamassarini referenced this issue in majamassarini/ogr Feb 14, 2023
@majamassarini
Drop PEP 517 installer warning
ee3c02c 
We have yet another warning, related with the PEP517,
which makes packit fail in retrieving the package version.

Let skip this warning until https://github.com/packit/packit/issues/1850
is done.
majamassarini referenced this issue in majamassarini/ogr Feb 14, 2023
@majamassarini
Drop PEP 517 installer warning
f4b4a7a 
We have yet another warning, related with the PEP517,
which makes packit fail in retrieving the package version.

Let skip this warning until https://github.com/packit/packit/issues/1850
is done.
@majamassarini majamassarini mentioned this issue Feb 14, 2023
Merged
softwarefactory-project-zuul bot referenced this issue Feb 14, 2023
@softwarefactory-project-zuul
Warnings make packit fail in parsing sandcastle command output (#769)
d68fc56 
Warnings make packit fail in parsing sandcastle command output

When we run the following as a sandcastle command:
python3 setup.py --version
we got 2 warning messages that make packit fail in parsing the command output:

licence_file is deprecated, which should be resolved by the first commit
Requirements should be satisfied by a PEP 517 installer:
when packit/packit#1850 will be closed this should disappear,
in the meantime just drop the warning, which should be solved by the second commit.

Reviewed-by: Tomas Tomecek <[email protected]>
@nforro nforro mentioned this issue Apr 3, 2023
Merged
1 task
@lachmanfrantisek lachmanfrantisek added complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. labels Apr 11, 2023
@nforro nforro mentioned this issue Jul 25, 2023
Closed
2 tasks
@jpopelka
Copy link
Member

jpopelka commented Sep 5, 2023 •
edited
Loading

I'm moving this to ogr since that's the last missing component.

As stated in the last paragraph of packit/packit#1913 (comment) you have to decide whether to do it:

  • the specfile way, i.e. have both, pyproject.yaml and setup.cfg in order to use setuptools<61 (there's setuptools-53 in RHEL9) as the build system or
  • the packit way, i.e. have only pyproject.yaml and use for example hatchling as the build system

I'd prefer the second one, I tried it in another project and it works like a charm for me.

@jpopelka jpopelka transferred this issue from packit/packit Sep 5, 2023
@jpopelka jpopelka added good-first-issue Good for newcomers. area/other Related to some other area/category than the specified ones. and removed area/fedora Related to Fedora ecosystem labels Sep 5, 2023
@gotmax23
Copy link

gotmax23 commented Sep 5, 2023

The other related task is getting rid of setuptools' pkg_resources from packit projects. pkg_resources has been deprecated in favor of importlib.metadata. pkg_resources raises a DeprecationWarning on import.

jpopelka added a commit to jpopelka/packit that referenced this issue Sep 6, 2023
@jpopelka
Replace pkg_resources (setuptools) with importlib
8a63e51 
packit/ogr#798 (comment)
@jpopelka jpopelka mentioned this issue Sep 6, 2023
Merged
1 task
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue Sep 6, 2023
@softwarefactory-project-zuul
Replace pkg_resources (setuptools) with importlib (#2068)
7ecfe45 
Replace pkg_resources (setuptools) with importlib

packit/ogr#798 (comment)
TODO:

 Write new tests or update the old ones to cover new functionality.

Reviewed-by: Laura Barcziová
@nforro nforro mentioned this issue Sep 26, 2023
Merged
@nforro nforro moved this from backlog to in-review in Packit Kanban Board Sep 26, 2023
@nforro nforro mentioned this issue Sep 27, 2023
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 2, 2023
@softwarefactory-project-zuul
Switch to pyproject.toml and hatchling and get rid of setuptools_scm_…
69de9bd 
…git_archive (#808)

Switch to pyproject.toml and hatchling and get rid of setuptools_scm_git_archive

Fixes #798.
Fixes #805.

Reviewed-by: Jiri Popelka
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Oct 2, 2023
softwarefactory-project-zuul bot added a commit to packit/requre that referenced this issue Oct 6, 2023
@softwarefactory-project-zuul
Packaging modernization (#275)
f0795b5 
Packaging modernization

Fixes #273.
Related to packit/ogr#798.

Reviewed-by: Jiri Popelka
Reviewed-by: Matej Focko
Reviewed-by: Nikola Forró
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/other Related to some other area/category than the specified ones. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. good-first-issue Good for newcomers. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to pyproject.toml and hatchling and get rid of setuptools_scm_git_archive nforro/ogr
4 participants
@jpopelka @TomasTomecek @gotmax23 @lachmanfrantisek