Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads and timeouts leave orphaned carts laying about #76

Open
karcaw opened this issue Apr 22, 2020 · 0 comments
Open

Downloads and timeouts leave orphaned carts laying about #76

karcaw opened this issue Apr 22, 2020 · 0 comments

Comments

@karcaw
Copy link

karcaw commented Apr 22, 2020

Pacifica Core Software versions

pacifica-cli 0.4.0
pacifica-downloader 0.3.5

Platform Details

any

Scenario:

When a download times out as in pacifica/pacifica-python-downloader#24, or in other cases of failure, the cart that was created is now orphaned. And since it probably still staging, it is now blocking other cart creation processes. If the user gets the error, he is just going to retry, which just starts another cart which has a lower chance of even starting a stage before the timeout will happen.
see pacifica/pacifica-python-downloader#25 as well

Steps to Reproduce:

try and download a large(>1TB) cart that times out
or just download a small cart, it still orphans it.

Expected Result:

timeouts and other errors should be handled better by cleaning up the carts.
once a download is complete, delete the cart so that space is reclaimed on the storage backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant