Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

row size && string_view of cell #30

Merged
merged 2 commits into from
Jul 3, 2022
Merged

row size && string_view of cell #30

merged 2 commits into from
Jul 3, 2022

Conversation

reder2000
Copy link
Contributor

Now with C++17 include guard

@reder2000
row size
b4e5fef 
string_view of cell with C++17 include guard
@reder2000
Copy link
Contributor Author

Fixes #25

@p-ranav
Copy link
Owner

p-ranav commented Jul 2, 2022

Do you mind updating the single_include version as well? Thanks!

@reder2000
add single file include
6b1679d 
make test work on MSVC
@reder2000
Copy link
Contributor Author

I've added the single file version. Also a quick fix to have test under MSVC

@p-ranav p-ranav merged commit 415b3a4 into p-ranav:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ranav p-ranav p-ranav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reder2000 @p-ranav