Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that an index is for the file being read #14

Open
oysstu opened this issue Sep 16, 2022 · 0 comments
Open

Ensure that an index is for the file being read #14

oysstu opened this issue Sep 16, 2022 · 0 comments

Comments

@oysstu
Copy link
Owner

oysstu commented Sep 16, 2022

File indexing has been disabled by default now (861a5f5), as it caused problems due to it being applied to xtf files automatically based on the file name alone. The index significantly speeds up reading parts of large files, but should have more protection in place to avoid trying to read a file with an invalid index.

Possible solutions include

  • Storing a hash of the xtf file in the index (perhaps only of the file header)
  • Reverting automatically to reading without an index if the magic numbers (0xFACE) cannot be found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant