Only show create RFD button to internal users

[mattdailis]

new.sh is in the private rfd repo. I imagine it's relatively simple, and not proprietary, so it would be great if it could be made public!

Of course, it's convenient for it to be colocated with the rfd repo, so I don't think I'm proposing it be moved somewhere else. Perhaps an empty rfd-template repo for others to use as a starting point would be appropriate?

[david-crespo]

I think we just want to make this line conditional on some attribute of the user that indicates they’re internal.

rfd-site/app/components/Header.tsx

Line 82 in fc95e76

<NewRfdButton />

I’m sure we can share the script and template, but it’s not very interesting: basically it creates a directory named 0123 containing a placeholder RFD asciidoc file (with the author and provided title templated in) in a branch also named 0123, and it pushes the branch.

Here is the template:

:showtitle:
:toc: left
:numbered:
:icons: font
:state: prediscussion
:discussion:
:revremark: State: {state} | {discussion}
:authors: Andy Hertzfeld <[email protected]>; Neal Firth <[email protected]>

= RFD <Number> <Title>
{authors}

== Determinations

== Open Questions

== Security Considerations

[bibliography]
== External References

[mattdailis]

Thanks! That's enough to get me started.

In case anyone else finds it useful to use as a starting point, here's my crude first cut based on David's description above: https://github.com/mattdailis/rfd-template

[augustuswm]

Agreed, we should limit that button to only users that have permission to create a new RFD. I have to get a new release of the api deployed but we have a permission variant now that we should be able to check to verify that.

Related to the new rfd script, we don't have any plains to make that not work, but we are finishing some work on api endpoints for creating a new RFD that does the same mechanical bits on behalf of the user. It is likely that we will update the create RFD button to show both options to the user.

[benjaminleonard]

FWIW I'm working on a PR to create a new RFD from that modal directly without the script. Based on this PR.