Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Sign Windows Binaries #943

Open
1 of 4 tasks
wfchandler opened this issue Dec 16, 2024 · 0 comments
Open
1 of 4 tasks

Code Sign Windows Binaries #943

wfchandler opened this issue Dec 16, 2024 · 0 comments
Labels
feature Issue for a new feature that does not break current functionality

Comments

@wfchandler
Copy link
Contributor

Target component

  • CLI
  • SDK
  • Something else
  • Not sure

Overview

As with #280 for macOS, we should be signing the Windows binaries to avoid a security warning when attempting to launch the binary from File Explorer.

This has less user impact than macOS as running an unsigned binary in powershell and command prompt works fine.

No developer account needed for this, we can use a cert and signtool.exe.

Implementation details

No response

Anything else you would like to add?

No response
@wfchandler wfchandler added the feature Issue for a new feature that does not break current functionality label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Issue for a new feature that does not break current functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wfchandler