Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto implement Same for types that impl Eq. #4

Open
andrewjstone opened this issue Dec 17, 2024 · 0 comments
Open

Auto implement Same for types that impl Eq. #4

andrewjstone opened this issue Dec 17, 2024 · 0 comments
Assignees

Comments

@andrewjstone
Copy link
Collaborator

If we want to retain backwards compatibility for f32 and f64 we'll need to put this behavior behind a feature that doesn't allow diffus to work with f32 and f64. This is a good tradeoff to make so that nobody has to implement Same manually.

Alternatively, if we wanted to go full hog and break backwards compat, we could just remove Same and force types to implement Eq.

CC @sunshowers

@andrewjstone andrewjstone self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant