-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve external ips row #2576
base: main
Are you sure you want to change the base?
Improve external ips row #2576
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added a little spacing to the left of the badge. Would be open to adding a slash between the last IP and the |
The badge is more visible, but we're not using it in other cases of overflow. Let's match the treatment elsewhere that just uses the mono. We might need some container to distinguish it from the addresses themselves but let's start there. |
I love the idea of linking to the networking tab. What if we used an info icon to link to the networking tab even when there is no overflow? That could let us avoid having to indicate which are floating or ephemeral inline. |
I've updated this to use the regular link text. Here it is when there's overflow: @david-crespo I'm not quite clear on your vision for the info icon as link to networking tab; could you go over your thoughts on that? |
This PR moves the Ephemeral IP to the end of the list of IPs in the minitable at the top of the screen. It also caps the number of IPs shown, with an overflow badge (
+3
or whatever) that directs the user to the Networking page.Showing two IPs, with the Floating IP first:
When there are more than 2 IPs:
Closes #2570