Fix sled instances prefetch #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
In my testing, the problems discussed in #1267 (comment) and #1125 don't seem to be a problem anymore, so I'm guessing they fixed the race conditions that were causing them. Of course it's always possible they're still there, but more likely to go how we prefer. In the short term I think that's ok, but eventually I'd like to understand why it was fixed. So it seems like this should be considered ok now: element={<Navigate to="abc" replace />
loader={AbcPage.loader}The explicit redirect |
david-crespo
force-pushed
the
sled-instances-prefetch
branch
from
df9a60d to
29d3261
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 4, 2023
oxidecomputer/console@bd65b9d...ae8218d * [ae8218df](oxidecomputer/console@ae8218df) bump msw to 2.0.3 for the real safari fix * [9a3f95a9](oxidecomputer/console@9a3f95a9) reduce dev console noise about local assets not served by MSW * [a61ecf24](oxidecomputer/console@a61ecf24) oxidecomputer/console#1809 * [50f3a5b2](oxidecomputer/console@50f3a5b2) bump recharts and react query * [1a2b5656](oxidecomputer/console@1a2b5656) oxidecomputer/console#1808 * [4c01cd68](oxidecomputer/console@4c01cd68) oxidecomputer/console#1800 * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [eee0eb2e](oxidecomputer/console@eee0eb2e) oxidecomputer/console#1805 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 * [d9cf1ef1](oxidecomputer/console@d9cf1ef1) bump sort imports plugin for vuln * [ba3a383e](oxidecomputer/console@ba3a383e) bump playwright to 1.39 (fix issue with z-index test)
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 4, 2023
### User-facing fixes * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 ### Full summary oxidecomputer/console@bd65b9d...ae8218d * [ae8218df](oxidecomputer/console@ae8218df) bump msw to 2.0.3 for the real safari fix * [9a3f95a9](oxidecomputer/console@9a3f95a9) reduce dev console noise about local assets not served by MSW * [a61ecf24](oxidecomputer/console@a61ecf24) oxidecomputer/console#1809 * [50f3a5b2](oxidecomputer/console@50f3a5b2) bump recharts and react query * [1a2b5656](oxidecomputer/console@1a2b5656) oxidecomputer/console#1808 * [4c01cd68](oxidecomputer/console@4c01cd68) oxidecomputer/console#1800 * [57cc1892](oxidecomputer/console@57cc1892) oxidecomputer/console#1802 * [47d76dbf](oxidecomputer/console@47d76dbf) oxidecomputer/console#1806 * [eee0eb2e](oxidecomputer/console@eee0eb2e) oxidecomputer/console#1805 * [60c2285e](oxidecomputer/console@60c2285e) oxidecomputer/console#1804 * [d9cf1ef1](oxidecomputer/console@d9cf1ef1) bump sort imports plugin for vuln * [ba3a383e](oxidecomputer/console@ba3a383e) bump playwright to 1.39 (fix issue with z-index test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on rack3 that when navigating from sleds list to sled detail (instances tab), there was a delay before the instances table would show up. We were prefetching it, so I figured out it's because the sled detail link goes to
/sleds/abc123, and then we do a little client-side redirect from there to/sleds/abc123/instances, and the loader is on the latter. Strictly speaking I think this might be a bug in React Router, but in the meantime we can fix this either by having the link from the sled list go directly to/sleds/abc123/instancesor by adding the loader to that redirect route (as I've done here). I vaguely remember there being a problem with this when I tried it before on another page, so I'll leave this up while we mull it over.