Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more actions menu on IP pool detail that lets you edit #2353

Closed
david-crespo opened this issue Aug 1, 2024 · 1 comment · Fixed by #2405
Closed

Add more actions menu on IP pool detail that lets you edit #2353

david-crespo opened this issue Aug 1, 2024 · 1 comment · Fixed by #2405

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Aug 1, 2024

Right now you can only edit from the list view. Check other resources with a detail view to see if we need to make this change, like VPC and instance.

@charliepark
Copy link
Contributor

charliepark commented Aug 29, 2024

I had a whole long thing here where I was wondering how we wanted to handle the URL pattern, but I think I've got it sorted.

Essentially, we can either leave the "Edit" action on the list page's dropdowns, or remove it. If we leave it in, clicking on it will take the user to the View page for the IP Pool, in the edit mode (so, with the sidebar). The sidebar won't show up on the IP Pools list view.

We will need, on saving the edit form, to reload the page with the new IP pool name in the URL. I feel like we've done that before, but haven't found a spot in the code where we do that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants