Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk size input no longer auto-updates with image change #1823

Closed
david-crespo opened this issue Nov 30, 2023 · 1 comment
Closed

Disk size input no longer auto-updates with image change #1823

david-crespo opened this issue Nov 30, 2023 · 1 comment
Assignees

Comments

@david-crespo
Copy link
Collaborator

Most likely introduced with #1582. The disk size input is supposed to update if the image is changed to one that's too big for the current size.

onChange={(id) => {
const image = images.find((i) => i.id === id)! // if it's selected, it must be present
const imageSizeGiB = image.size / GiB
if (diskSizeField.value < imageSizeGiB) {
const nearest10 = Math.ceil(imageSizeGiB / 10) * 10
diskSizeField.onChange(nearest10)
}
}}

2023-11-29-disk-size-input-bug.mp4
@charliepark
Copy link
Contributor

Fixed this back in #1829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants