Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] more errors with extra slashes in URI #40341

Open
jnweiger opened this issue Sep 6, 2022 · 2 comments
Open

[QA] more errors with extra slashes in URI #40341

jnweiger opened this issue Sep 6, 2022 · 2 comments
Labels

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Sep 6, 2022

Seen while testing #34365 with 10.11.0-beta.1

The following cases are fixed since #40216:

  • curl -u admin:admin http://localhost//remote.php//dav/files/admin/test.txt # double slashes at start
  • curl -u admin:admin http://localhost//remote.php//dav//files//admin//test.txt # double slashes everywhere
  • curl -u admin:admin http://localhost////remote.php//dav/files/admin/test.txt # many slashes at start

This still explodes

  • curl -u admin:admin http://localhost/remote.php///dav/files/admin/test.txt # many slashes after remote.php
< HTTP/1.1 500 Internal Server Error
< Date: Tue, 06 Sep 2022 07:17:11 GMT
< Server: Apache/2.4.41 (Ubuntu)
...
< Content-Length: 270
< Connection: close
< Content-Type: application/xml; charset=utf-8
< 
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>LogicException</s:exception>
  <s:message>Requested uri (/remote.php///dav/files/admin/test.txt) is out of base uri (/remote.php/dav/)</s:message>
</d:error>

Expected behaviour:

  • redundant slashes are harmless.
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant