Skip to content

Commit

Permalink
api steps used instead of web ui step for then step
Browse files Browse the repository at this point in the history
  • Loading branch information
@grgprarup
grgprarup committed Dec 21, 2022
1 parent 0827bf6 commit 53ffd49
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 42 deletions.
3 changes: 2 additions & 1 deletion tests/acceptance/features/bootstrap/WebUISharingContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,10 @@ public function theUserSharesUsingWebUIWithoutClosingDialog(
$users_array[] = $user;
}
}
$name = join(", ", $users_array);
$nameToMatch = join(", ", $users_array);
$this->sharingDialog->shareWithUsers(
$name,
$nameToMatch,
$this->getSession(),
$quiet,
$maxRetries
Expand Down
3 changes: 2 additions & 1 deletion tests/acceptance/features/lib/FilesPageElement/SharingDialog.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -415,13 +415,14 @@ public function shareWithUser(
*/
public function shareWithUsers(
?string $name,
?string $nameToMatch,
Session $session,
bool $quiet,
int $maxRetries = 5
): void {
$this->shareWithUserOrGroup(
$name,
$name . $this->suffixToIdentifyMultipleUsers,
$nameToMatch . $this->suffixToIdentifyMultipleUsers,
$session,
$quiet,
$maxRetries
Expand Down
63 changes: 23 additions & 40 deletions tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,8 @@ Feature: Sharing files and folders with internal users
And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "lorem.txt"
And user "Alice" has logged in using the webUI
When the user shares file "lorem.txt" with users "Brian,Carol" using the webUI
And the user re-logs in as "Brian" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
When the user re-logs in as "Carol" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
Then as "Brian" file "lorem.txt" should exist
And as "Carol" file "lorem.txt" should exist


Scenario: user shares folder with multiple users at once
Expand All @@ -381,12 +377,8 @@ Feature: Sharing files and folders with internal users
And user "Alice" has created folder "simple-folder"
And user "Alice" has logged in using the webUI
When the user shares folder "simple-folder" with users "Brian,Carol" using the webUI
And the user re-logs in as "Brian" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
And the user re-logs in as "Carol" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
Then as "Brian" folder "simple-folder" should exist
And as "Carol" folder "simple-folder" should exist


Scenario Outline: user shares file with multiple users including non-existing user at once
Expand All @@ -397,35 +389,34 @@ Feature: Sharing files and folders with internal users
| Carol |
And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "lorem.txt"
And user "Alice" has logged in using the webUI
When the user shares file "lorem.txt" with users "<users>" using the webUI
And the user re-logs in as "Brian" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
When the user re-logs in as "Carol" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
When the user shares file "lorem.txt" with users "<usernames>" using the webUI
Then a notification should be displayed on the webUI with the text "Could not be shared with the following users: David"
And as "Brian" file "lorem.txt" should exist
And as "Carol" file "lorem.txt" should exist
Examples:
| users |
| usernames |
| Brian,Carol,David |
| Brian,David,Carol |
| David,Brian,Carol |


Scenario: user shares folder with multiple users including non-existing user at once
Scenario Outline: user shares folder with multiple users including non-existing user at once
Given these users have been created with default attributes and without skeleton files:
| username |
| Alice |
| Brian |
| Carol |
And user "Alice" has created folder "simple-folder"
And user "Alice" has logged in using the webUI
When the user shares folder "simple-folder" with users "Brian,David,Carol" using the webUI
And the user re-logs in as "Brian" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
And the user re-logs in as "Carol" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
When the user shares folder "simple-folder" with users "<usernames>" using the webUI
Then a notification should be displayed on the webUI with the text "Could not be shared with the following users: David"
And as "Brian" folder "simple-folder" should exist
And as "Carol" folder "simple-folder" should exist
Examples:
| usernames |
| Brian,Carol,David |
| Brian,David,Carol |
| David,Brian,Carol |


Scenario: user shares file with multiple users having exact same group name
Expand All @@ -438,12 +429,8 @@ Feature: Sharing files and folders with internal users
And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "lorem.txt"
And user "Alice" has logged in using the webUI
When the user shares file "lorem.txt" with users "Brian,Carol" using the webUI
And the user re-logs in as "Brian" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
When the user re-logs in as "Carol" using the webUI
Then file "lorem.txt" should be listed on the webUI
And file "lorem.txt" should be marked as shared by "Alice" on the webUI
Then as "Brian" file "lorem.txt" should exist
And as "Carol" file "lorem.txt" should exist


Scenario: user shares folder with multiple users having exact same group name
Expand All @@ -456,9 +443,5 @@ Feature: Sharing files and folders with internal users
And user "Alice" has created folder "simple-folder"
And user "Alice" has logged in using the webUI
When the user shares folder "simple-folder" with users "Brian,Carol" using the webUI
And the user re-logs in as "Brian" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
And the user re-logs in as "Carol" using the webUI
Then folder "simple-folder" should be listed on the webUI
And folder "simple-folder" should be marked as shared by "Alice" on the webUI
Then as "Brian" folder "simple-folder" should exist
And as "Carol" folder "simple-folder" should exist

0 comments on commit 53ffd49

Please sign in to comment.