Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in top menu don't work on small Chrome screens #56

Open
naasking opened this issue Sep 25, 2015 · 8 comments
Open

Links in top menu don't work on small Chrome screens #56

naasking opened this issue Sep 25, 2015 · 8 comments

Comments

@naasking
Copy link

Desktop or mobile chrome, if you're viewing mincss.com in a small screen such that you see the mobile top menu, and you try to click a link in that menu, it simply collapses the menu and doesn't go anywhere.

@naasking
Copy link
Author

Same problem on IE11.

@owenversteeg
Copy link
Owner

Hi! Thanks for reporting this. Just confirmed on mobile and desktop Chrome, I'll confirm IE11 when I have a chance. @scottaohara do you have a Windows box running you can test this on?

I'll get to work on a solution ASAP.

@naasking
Copy link
Author

Sure, just post back here with a URL and I'll let you know.

@scottaohara
Copy link
Collaborator

i'll take a look asap as well. today's kind of hectic, but within the next few days i can probably get on this

@scottaohara
Copy link
Collaborator

@owenversteeg confirmed that this is happening on IE11.

i have a solution that fixes basically all of the issues brought up around the nav, which includes a bit of restyling / using the :target pseudo selector instead of :focus to get the nav to open (ie/chrome are closing the menu due to the changing of focus from the

to the nav links, and aren't registering the click because focus changes before the click event fires, i'm assuming).

the main issue i see with my solution is that :target only works in ie9+, so that obviously is an issue for the pre ie9 support.

i'm going to submit my work in a separate branch so you can take a look n' see if it inspires you to think of an alternative.

@scottaohara
Copy link
Collaborator

FYI in the index file I'm pushing, i'm referencing an uncompressed css file in sass/min-master.css.

figured i'd leave it in there for testing purposes as this is likely not the optimal solution at this time.

@owenversteeg
Copy link
Owner

@scottaohara Oh great thanks! I just tested it on iOS and Android and it seems good. Only issue is that the padding for the close button hangs off the navbar, so that may need to be fixed.

@deanishe
Copy link

deanishe commented Oct 3, 2017

Any news on this?

I downloaded Min and I'm having the same issue. On the mincss.com homepage, it seems to be fixed, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants