Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

[Analyzer] var_dump leftovers #342

Open
kilgaloon opened this issue Nov 6, 2017 · 5 comments
Open

[Analyzer] var_dump leftovers #342

kilgaloon opened this issue Nov 6, 2017 · 5 comments

Comments

@kilgaloon
Copy link
Contributor

It will be good to analyze var_dump leftovers in project, and to add support for other functions that cause same behavior.

@ddmler
Copy link
Collaborator

ddmler commented Nov 6, 2017

Hi we have an analyzer that does this: https://github.com/ovr/phpsa/blob/master/src/Analyzer/Pass/Expression/FunctionCall/DebugCode.php
it currently checks for var_dump, var_export, debug_zval_dump. If you know more you can add them to the list.
Or did you mean something different?

@kilgaloon
Copy link
Contributor Author

What about supporting dumps from another popular frameworks, like dd() in laravel?

@ddmler
Copy link
Collaborator

ddmler commented Nov 6, 2017

Sure we can add those.

@ddmler
Copy link
Collaborator

ddmler commented Dec 7, 2017

I added dd and dump (laravel, symfony) in this commit 69939ed
Not sure which frameworks are used so widely that it makes sense to add their debug function, but if you know some more feel free to add those, too @kilgaloon

@kilgaloon
Copy link
Contributor Author

Also i think it will be good we can move this also to config, so people can setup those, sure we can insert there some defaults, but maybe we can give them option to more through config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants