Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in unpacking not fully supported #13

Open
DokaDoka opened this issue Oct 10, 2022 · 1 comment
Open

in unpacking not fully supported #13

DokaDoka opened this issue Oct 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@DokaDoka
Copy link
Member

image

@DokaDoka DokaDoka added the bug Something isn't working label Oct 10, 2022
thelindat added a commit that referenced this issue Oct 10, 2022
It is valid syntax but this is just a lazy workaround (for now?) for #13.
@thelindat
Copy link
Member

thelindat commented Oct 10, 2022

For now I've replaced the whitespace check with space and tab; would require detecting and ignoring comments otherwise.

Proper detection of in syntax likely requires a real Lua parser rather than the basic pattern matching used right now; we need to ensure any instances of in aren't part of a comment, string, function, iterator, etc.

However in syntax has also been known to cause crashes* in the Lua runtime in some rare cases, and per the author of LuaGLM

Should probably avoid using any of the syntax extensions.

* Seemingly when failing to unpack the return value from a function? Can't quite remember. Safe navigation can lead to funny errors too.

@thelindat thelindat changed the title in behaves incorrectly when commented in unpacking not fully supported Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants